From 6a53ff946dcd16c7c513d42432f6686e6f4d10c2 Mon Sep 17 00:00:00 2001 From: m-tartari <37861893+m-tartari@users.noreply.github.com> Date: Fri, 8 May 2026 17:58:22 +0200 Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20refactor(people):=20use=20?= =?UTF-8?q?best=20practices=20for=20props-driven=20state=20updates?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit @see https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes --- src/components/molecules/EmplyeeStack/index.tsx | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/components/molecules/EmplyeeStack/index.tsx b/src/components/molecules/EmplyeeStack/index.tsx index b7a8c5b..a95dd26 100644 --- a/src/components/molecules/EmplyeeStack/index.tsx +++ b/src/components/molecules/EmplyeeStack/index.tsx @@ -1,4 +1,4 @@ -import { FC, useEffect, useState } from 'react' +import { FC, useState } from 'react' import { Box, IconButton } from '@mui/material' import ShuffleIcon from '@mui/icons-material/NextPlan' @@ -21,10 +21,12 @@ const EmplyeeStack: FC = ({ onClick, }) => { const [items, setItems] = useState(initialItems) + const [prevInitialItems, setPrevInitialItems] = useState(initialItems) - useEffect(() => { + if (prevInitialItems !== initialItems) { + setPrevInitialItems(initialItems) setItems(initialItems) - }, [initialItems]) + } const handleTopClick = () => { if (items.length) {