From f2df23ca92f18dbdb6b4691fc56d960de0e7b465 Mon Sep 17 00:00:00 2001 From: m-tartari <37861893+m-tartari@users.noreply.github.com> Date: Mon, 25 Mar 2024 09:48:43 +0100 Subject: [PATCH 1/3] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20refactor(home):=20fix?= =?UTF-8?q?=20project=20subtitle=20spacing?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/components/pages/MainPage/MainPage.tsx | 8 ++++---- src/components/pages/ProjectsPage/ProjectsPage.tsx | 12 ++++++------ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/components/pages/MainPage/MainPage.tsx b/src/components/pages/MainPage/MainPage.tsx index 4673bff..59056db 100644 --- a/src/components/pages/MainPage/MainPage.tsx +++ b/src/components/pages/MainPage/MainPage.tsx @@ -30,7 +30,7 @@ const MainPage = () => { caption={ <> - + Software Engineer @ IIT @@ -54,7 +54,7 @@ const MainPage = () => { caption={ <> - + Software Engineer @ IIT @@ -76,7 +76,7 @@ const MainPage = () => { caption={ <> - + Embedded Engineer @ IIT @@ -103,7 +103,7 @@ const MainPage = () => { fontSize="small" href="https://drive.google.com/file/d/1wBfvAzy9N8uChNxNj9Kd_hcvI0Qq3uQj/view?usp=sharing" /> - + Master Thesis @ WUT diff --git a/src/components/pages/ProjectsPage/ProjectsPage.tsx b/src/components/pages/ProjectsPage/ProjectsPage.tsx index 88ac884..06399f2 100644 --- a/src/components/pages/ProjectsPage/ProjectsPage.tsx +++ b/src/components/pages/ProjectsPage/ProjectsPage.tsx @@ -28,7 +28,7 @@ const ProjectsPage = () => { sx={{ color: 'text.secondary' }} /> {/* */} - + Software Engineer @ IIT @@ -50,7 +50,7 @@ const ProjectsPage = () => { Software Engineer @ IIT - + Software Engineer @ IIT @@ -76,7 +76,7 @@ const ProjectsPage = () => { href="https://drive.google.com/file/d/1wBfvAzy9N8uChNxNj9Kd_hcvI0Qq3uQj/view?usp=sharing" sx={{ color: 'text.secondary' }} /> - + Master Thesis @ WUT @@ -245,7 +245,7 @@ const ProjectsPage = () => { href="https://github.com/ADVRHumanoids/motor_calibration" sx={{ color: 'text.secondary' }} /> - + Embedded Engineer @ IIT @@ -272,7 +272,7 @@ const ProjectsPage = () => { href="https://drive.google.com/file/d/0B1z42QMR-0UtYzBYSVhRV3ZPWk0/view?usp=sharing" sx={{ color: 'text.secondary' }} /> - + Bachelor Thesis @ TONGJI @@ -294,7 +294,7 @@ const ProjectsPage = () => { href="https://drive.google.com/file/d/0B1z42QMR-0UtSkxRVzJPTk1IX0k/view?usp=sharing" sx={{ color: 'text.secondary' }} /> - + Bachelor Thesis @ UNIBO From bd60fcf38eeb736f1a20ec35aa4658622d902e7f Mon Sep 17 00:00:00 2001 From: m-tartari <37861893+m-tartari@users.noreply.github.com> Date: Mon, 25 Mar 2024 09:50:13 +0100 Subject: [PATCH 2/3] =?UTF-8?q?=E2=9C=A8=20feat(icons):=20add=20ExtrenalAp?= =?UTF-8?q?pIconLink?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/components/atoms/IconLinks/IconLinks.test.tsx | 3 ++- src/components/atoms/IconLinks/IconLinks.tsx | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/components/atoms/IconLinks/IconLinks.test.tsx b/src/components/atoms/IconLinks/IconLinks.test.tsx index 8ba1d59..5bfb814 100644 --- a/src/components/atoms/IconLinks/IconLinks.test.tsx +++ b/src/components/atoms/IconLinks/IconLinks.test.tsx @@ -12,7 +12,8 @@ const labels: { [key: string]: string } = { LinkedInIconLink: 'LinkedIn-button', AcademyIconLink: 'Academy-button', VideoIconLink: 'Video-button', - ExtrernalIconLink: 'External-link-button', + ExternalIconLink: 'External-link-button', + ExternalAppIconLink: 'External-app-button', } vi.stubGlobal('open', vi.fn()) diff --git a/src/components/atoms/IconLinks/IconLinks.tsx b/src/components/atoms/IconLinks/IconLinks.tsx index 09008d6..2994577 100644 --- a/src/components/atoms/IconLinks/IconLinks.tsx +++ b/src/components/atoms/IconLinks/IconLinks.tsx @@ -1,4 +1,4 @@ -import { Email, LinkedIn, GitHub, Description, OndemandVideo, School, OpenInNew } from '@mui/icons-material' +import { Email, LinkedIn, GitHub, Description, OndemandVideo, School, OpenInNew, OpenInBrowser } from '@mui/icons-material' import { Badge, IconButtonProps, SvgIcon } from '@mui/material' import IconButton from '../IconButton' @@ -41,4 +41,5 @@ export const GitHubIconLink = (props: IconLinkProps) => export const AcademyIconLink = (props: IconLinkProps) => export const VideoIconLink = (props: IconLinkProps) => -export const ExtrernalIconLink = (props: IconLinkProps) => +export const ExternalIconLink = (props: IconLinkProps) => +export const ExternalAppIconLink = (props: IconLinkProps) => From cb2a26941145e87ab07bfb0898bf26ab2903f8b9 Mon Sep 17 00:00:00 2001 From: m-tartari <37861893+m-tartari@users.noreply.github.com> Date: Mon, 25 Mar 2024 09:50:39 +0100 Subject: [PATCH 3/3] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20refactor(projects):=20?= =?UTF-8?q?add=20modular=20external=20link?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/components/atoms/Publication/Publication.tsx | 6 ++---- src/components/pages/MainPage/MainPage.tsx | 3 ++- src/components/pages/ProjectsPage/ProjectsPage.tsx | 3 ++- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/components/atoms/Publication/Publication.tsx b/src/components/atoms/Publication/Publication.tsx index fdb61bb..d02dafa 100644 --- a/src/components/atoms/Publication/Publication.tsx +++ b/src/components/atoms/Publication/Publication.tsx @@ -1,6 +1,6 @@ import React from 'react' import { Box, SxProps, Theme, Typography, TypographyProps } from '@mui/material' -import { ExtrernalIconLink } from '..' +import { ExternalIconLink } from '..' type AwardEntryProps = { year: string | number @@ -26,9 +26,7 @@ const Publication = ({ Component = Box, ...props }: AwardEntryProps) => { {props.title} , In: {props.location} - {typeof props.link !== 'undefined' && ( - - )} + {typeof props.link !== 'undefined' && } diff --git a/src/components/pages/MainPage/MainPage.tsx b/src/components/pages/MainPage/MainPage.tsx index 59056db..ffe67ce 100644 --- a/src/components/pages/MainPage/MainPage.tsx +++ b/src/components/pages/MainPage/MainPage.tsx @@ -2,7 +2,7 @@ import React from 'react' import { Box, Typography } from '@mui/material' import { ViewportProvider } from 'components/utils/viewport' -import { AcademyIconLink, DescriptionIconLink, GitHubIconLink, VideoIconLink } from 'components/atoms' +import { AcademyIconLink, DescriptionIconLink, ExternalAppIconLink, GitHubIconLink, VideoIconLink } from 'components/atoms' import { Footer, Hero, Toobar, ProjectSpotlight } from 'components/molecules' const MainPage = () => { @@ -54,6 +54,7 @@ const MainPage = () => { caption={ <> + Software Engineer @ IIT diff --git a/src/components/pages/ProjectsPage/ProjectsPage.tsx b/src/components/pages/ProjectsPage/ProjectsPage.tsx index 06399f2..6c3475c 100644 --- a/src/components/pages/ProjectsPage/ProjectsPage.tsx +++ b/src/components/pages/ProjectsPage/ProjectsPage.tsx @@ -1,6 +1,6 @@ import { Box, Divider, Link, Typography } from '@mui/material' -import { GitHubIconLink, DescriptionIconLink, VideoIconLink, AcademyIconLink } from 'components/atoms' +import { GitHubIconLink, DescriptionIconLink, VideoIconLink, AcademyIconLink, ExternalAppIconLink } from 'components/atoms' import { Project } from 'components/molecules' import { Page } from 'components/templates' @@ -50,6 +50,7 @@ const ProjectsPage = () => { Software Engineer @ IIT + Software Engineer @ IIT